Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2797 : Improve untracked files message during eject #2838

Closed

Conversation

Dubes
Copy link
Contributor

@Dubes Dubes commented Jul 22, 2017

This attempts to improve the message shown to user when ejecting on a git repo having untracked changes ( Issue: #2797 )

Proposed message

Your git working tree is dirty. This will make it hard for you to resolve any unintended consequences eject may have on your changes.
Please use git status to verify the changed files, then either remove , stash or commit them before trying again.

Message break down:

  • state the root cause
  • state why this is not allowed
  • hint for the user to identify files causing problems
  • hint for the user towards action they can commit

I did not list the files (as was done previously) as that may lead users to more confusion (why is CRA having problem with this file etc.), instead tell the users how they can find it.

Testing:
Screenshot attached:
image

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Dubes
Copy link
Contributor Author

Dubes commented Jul 23, 2017

doesn't look like my changes broke the builds, but I cannot rerun them to verify.

@xjlim xjlim mentioned this pull request Nov 6, 2017
@Timer
Copy link
Contributor

Timer commented Nov 7, 2017

Hi! We just merged #3416 to improve how files are displayed, but would still appreciate your adjusted wording.

If possible, I'd like it to be a bit more terse and leave current wording. How about we just add another line after the instructions at the end?

Modify "This will make it hard for you to resolve any unintended consequences eject may have on your changes" to be-post instruction, like "Doing this will make it easy" etc.

@Dubes
Copy link
Contributor Author

Dubes commented Nov 9, 2017

Sure, will update it...

@Timer
Copy link
Contributor

Timer commented Nov 9, 2017

Thanks! Sorry for letting this slip through the cracks.

@Timer Timer added this to the 1.0.x milestone Nov 9, 2017
@Dubes
Copy link
Contributor Author

Dubes commented Nov 13, 2017

No Problem! it happens :-)
I adapted the message and resolved the conflict via browser, but I am new to Github and not sure if I messed something up (I still see the conflict message). Do let me know if there is something I need to do.

@gaearon gaearon modified the milestones: 1.0.x, 2.0.x, 2.x Jan 14, 2018
@Timer
Copy link
Contributor

Timer commented Sep 26, 2018

Hmm, I'm not super fond of any of this wording. Let's revisit it sometime in the future.

Thanks for the time you put into this!

@Timer Timer closed this Sep 26, 2018
@Timer Timer modified the milestones: 2.x, 2.0.0 Oct 1, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants