Display Build Size Difference

[elijahmanor]

This PR closes #326

Test Plan

1. Run npm run build without a build folder
   • Should not show any difference
2. Run npm run build with a build folder with no changes
   • Should show a green positive difference of zero
   • example: (+0 B)
3. Run npm run build with a build folder after adding new code
   • Should show a red positive difference of some number
   • example: (+3 B)
4. Run npm run build with a build folder after removing old code.
   • Should show green negative difference of some number
   • example: (-3 B)

[ghost]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

[gaearon]

This should be in dependencies of this project.

[elijahmanor]

Just signed the Contributor License Agreement, moved the devDependency to a dependency, squashed, and force pushed to this feature branch

[ghost]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[gaearon]

A few notes:

• I don’t think yellow is the best choice for the build size itself. We use it for warnings, and it makes me feel uneasy about build now. 😄 Can we use cyan or some other color there? Maybe even white would work there now that we have diffs. We could tweak the color of filename if you don’t want too much cyan. Please try a few different stylings and see what works best given the meanings we assign to colors.
• I’d like to display red for >= + 50 KB, yellow for + 0 ... 50 KB, and green for - ... KB.
• I currently see (+ 0 KB) on rebuilds, this shouldn’t be happening. Diff should not be displayed on unchanged files.

[gaearon]

Code style: please only use multiline blocks.

if (...) {
  ...
}

[elijahmanor]

@gaearon Ahh, I didn't realize about the previous meaning of yellow. I changed it in hopes the size difference would stand out. I like your idea about color thresholds.

I wasn't sure what to do with a 2nd build when nothing changed, so I decided to show (+ 0 KB) to indicate that it was a good thing they didn't increase in size (Test Plan 2). However, I also understand not wanting to see anything at all, so I'll update that logic.

Sure, I'll update the multiline block. Thanks for the feedback. I'll work on those things tonight and update the PR. Do you want to me squash the commits or do you prefer keeping them separate so you can see the difference? Also, do you want me to rebase against master before I push my updates?

[alexzherdev]

@gaearon Btw I think white should be avoided as some people might still have white as the terminal's background? 😃

[gaearon]

Btw I think white should be avoided as some people might still have white as the terminal's background?

Sorry, I meant “default” color (no chalk). Great point 👍

[gaearon]

Do you want to me squash the commits or do you prefer keeping them separate so you can see the difference? Also, do you want me to rebase against master before I push my updates?

Please rebase against master but don’t worry about squashing—GH will do that. I only ask to rebase in case I merge something conflicting in the meantime. I don’t expect to though.

[elijahmanor]

Sorry, I meant “default” color (no chalk). Great point 👍

Cool, I'll keep that in mind. Thanks @gaearon @alexzherdev for the clarification

Please rebase against master but don’t worry about squashing

👍

[elijahmanor]

Okay, @gaearon I made the adjustments you requested. Since I'm now only showing file-size difference for files that changed I needed to add strip-ansi to assist with the padding logic (to remove the unicode characters used by chalk).

I fetched/merged from upstream/master and rebased this feature branch based on that.

If you find anything else please let me know and I'll be happy to update this PR.

Thanks!

[gaearon]

Thank you!

[gaearon]

This was released in 0.2.2 but I forgot to add a changelog entry.
Doing it now.
Thanks again!