Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screencast to use npx #3810

Merged
merged 6 commits into from
Jan 16, 2018
Merged

Update screencast to use npx #3810

merged 6 commits into from
Jan 16, 2018

Conversation

marionebl
Copy link
Contributor

As asked in #3677, this updates the screencast to use npx.

@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

Can you please remove unrelated edits and change the PR target to be next?

@marionebl marionebl changed the base branch from master to next January 16, 2018 00:02
@marionebl marionebl force-pushed the docs-svg-demo branch 2 times, most recently from 005dfb5 to 0da8db2 Compare January 16, 2018 00:21
@marionebl
Copy link
Contributor Author

Done! Struggled a bit with getting changes from next merged cleanly

@gaearon
Copy link
Contributor

gaearon commented Jan 16, 2018

I hate to be nitpicky but any chance you could make it so that we don't see the history of the past npx calls being autocompleted?

* The previous version was recorded on a fish shell, which has
a history suggestion feature that can not be disabled

* The new version uses zsh as shell to avoid the history
suggestions in the cast

* The new version has been created with scripts that are subject
of a separate PR
@gaearon gaearon added this to the 2.x milestone Jan 16, 2018
@gaearon gaearon merged commit 272edff into facebook:next Jan 16, 2018
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
* Use npx for screencast

* Use updated screencast

* Update screencast to version without history

* The previous version was recorded on a fish shell, which has
a history suggestion feature that can not be disabled

* The new version uses zsh as shell to avoid the history
suggestions in the cast

* The new version has been created with scripts that are subject
of a separate PR

* Use screencast without autosuggestions
@Timer Timer modified the milestones: 2.x, 2.0.0 Oct 1, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants