Bump babel-related deps #4159
Merged
Bump babel-related deps #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowhatdoido
reviewed
Mar 15, 2018
| "@babel/plugin-transform-destructuring": "7.0.0-beta.41", | ||
| "@babel/plugin-transform-react-constant-elements": "7.0.0-beta.41", | ||
| "@babel/plugin-transform-react-display-name": "7.0.0-beta.41", | ||
| "@babel/plugin-transform-react-jsx": "7.0.0-beta.41", |
There was a problem hiding this comment.
Just curious, is there a reason you bump @babel/plugin-transform-react-jsx
up to 7.0.0-beta.41 if you remove the plugin from packages/babel-preset-react-app/index.js in d103b41?
Edit: clarification
There was a problem hiding this comment.
Nah, just oversight. Will fix and update to beta.42 (which will fix the .slice() error and give a better error message) in a sec after we do the release.
existentialism
force-pushed
the
bump-babel
branch
from
d103b41
to
394b21b
Compare
iansu
approved these changes
Mar 15, 2018
Merged
|
Thanks @existentialism! |
|
@iansu Please always add a tag and a milestone, that’s how we know to include change in release notes |
|
@gaearon I'll make sure I do that from now on. |
rezak-otmani
pushed a commit
to rezak-otmani/create-react-app
that referenced
this pull request
Mar 19, 2018
tvalentius
added a commit
to tvalentius/create-react-app
that referenced
this pull request
Mar 20, 2018
Bump babel-related deps (facebook#4159)
kellyrmilligan
added a commit
to kellyrmilligan/create-react-app
that referenced
this pull request
Mar 22, 2018
* next: Fix typos in example monorepo documentation. (facebook#4164) Minor fixes to CI (facebook#4193) Change no-unused-vars 'args' from none to all to show warning on destructured objects Bump babel-related deps (facebook#4159) Remove ref to non free resource (facebook#4160)
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* Add explicit dep on plugin-proposal-object-rest-spread to babel-preset-react-app * Bump babel-related deps to beta.42 * Pass useBuiltIns directly to react-preset
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3891.
Fixes #4154.