Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable check #4447

Closed
wants to merge 1 commit into from
Closed

Re-enable check #4447

wants to merge 1 commit into from

Conversation

stramel
Copy link

@stramel stramel commented May 12, 2018

Re-enables check now that #2176 is closed

Re-enables check now that #2176 is closed
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@stramel
Copy link
Author

stramel commented May 12, 2018

signed it 👍

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

object: 'require',
property: 'ensure',
message:
'Please use import() instead. More info: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#code-splitting',
Copy link
Contributor

@bondz bondz May 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you correct the url. The repo is no longer here and you should target next instead, as master is no longer taking updates.

@Timer
Copy link
Contributor

Timer commented May 13, 2018

I'm pretty sure this change has already been made on the next branch.

'no-restricted-properties': [
'error',
{
object: 'require',
property: 'ensure',
message:
'Please use import() instead. More info: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#code-splitting',
},
{
object: 'System',
property: 'import',
message:
'Please use import() instead. More info: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#code-splitting',
},
],

Thanks a lot for the PR, though!

@Timer Timer closed this May 13, 2018
@stramel
Copy link
Author

stramel commented May 13, 2018

Great! Sorry I didn't realize that the branches were switched

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants