Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webp images #458

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Webp images #458

merged 1 commit into from
Aug 23, 2016

Conversation

gafemoyano
Copy link
Contributor

Heres a .webp file for testing.

I tested locally by adding the image via ES6 importand as a background-image property on css.

@ghost
Copy link

ghost commented Aug 17, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost ghost added the CLA Signed label Aug 17, 2016
@ghost
Copy link

ghost commented Aug 17, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Aug 22, 2016

Sorry for the trouble—we recently added another extension, and this now need rebasing.
Can you please rebase?

@gaearon gaearon added this to the 0.3.0 milestone Aug 22, 2016
@ghost ghost added the CLA Signed label Aug 22, 2016
@ghost ghost added the CLA Signed label Aug 23, 2016
@ghost ghost added the CLA Signed label Aug 23, 2016
@gafemoyano
Copy link
Contributor Author

Hi Dan

I've updated the pull request. Please let me know if everything is ok.

@gaearon gaearon merged commit dcdcab0 into facebook:master Aug 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 23, 2016

Looks great.
Can you please also send a PR to pushstate-server which we recommend for testing built site?
See this PR as an example: scottcorgan/pushstate-server#23.

@gafemoyano
Copy link
Contributor Author

Here it is:
Added webp images #25

@gaearon gaearon modified the milestones: 0.2.3, 0.3.0 Aug 25, 2016
gaearon pushed a commit that referenced this pull request Aug 25, 2016
@gafemoyano @gaearon
Added support for webp images in #442 (#458)
9e81d1c
This was referenced Aug 25, 2016
Closed
Merged
stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
@gafemoyano
Added support for webp images in facebook#442 (facebook#458)
3875d1b
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@gafemoyano @feiqitian
Added support for webp images in facebook#442 (facebook#458)
6c17901
@dugagjin dugagjin mentioned this pull request Dec 6, 2018
Merged
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
0.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@gafemoyano @gaearon