Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore coverage folder generated by jest #541

Merged
merged 1 commit into from
Sep 2, 2016

Conversation

ldesplat
Copy link
Contributor

@ldesplat ldesplat commented Sep 2, 2016

Thank you for create-react-app. Really amazing tools greatly packaged up.

I always run my tests with coverage to maintain 100% code coverage so I tried create-react-app 0.3.0 but noticed the coverage folder was not getting ignored by git.

So, this simply ignores the coverage folder since I don't think it belongs in source control.

@ghost
Copy link

ghost commented Sep 2, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost
Copy link

ghost commented Sep 2, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Sep 2, 2016
@gaearon gaearon merged commit ac04277 into facebook:master Sep 2, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 2, 2016

Thanks!

stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants