Adding an exception for manifest.json when loading as json, fixes #558 #565
Conversation
ghost
added
the
| // A special case for manifest.json to place it into build root directory. | ||
| { | ||
| test: /\/manifest.json$/, | ||
| include: [paths.appSrc], |
There was a problem hiding this comment.
One thing I’m not sure about is whether it should be in src. I’m leaning towards putting it on the top level because you can’t import it from code now—you’ll get a string. What do you think?
There was a problem hiding this comment.
@gaearon sure, can you please explain why should it load differently from the top level in the code and differently from the template? I've tried some configurations and can't get it to load differently even though it's in the top level (by top level you mean template dir right?
There was a problem hiding this comment.
Sorry I wasn't clear. There is no way to make it load differently depending on context. Since we want it to resolve to filename, I wanted to move it away from src folder. The reason is that people normally expect that they can import JS/JSON inside src folder and treat it as a module. So it would be weird if src/manifest.json somehow was treated specially and you couldn't import it as a module from, for example, src/index.js. However we never officially supported importing modules from outside src folder so in this case special behavior seems like fair game. Does this make sense?
|
Can you please review @mxstbr @eanplatter? |
|
I just read about the web app manifest and it turns out the standard file extension for it is Considering this, I think it would be better to only support manifests using the |
|
Sorry for the really long turnaround time. I was on a vacation, and couldn’t review it properly. In the end I decided to go with a different approach that also solves a dozen of other related issues: #703. I know it’s frustrating so I hope this doesn’t turn you off from future contributions. This was a really complicated issue because of all corner cases, and I think #703 is a better way to address it, but it took me a few weeks to figure out how to do it properly. |
|
@gaearon no problem, I like that solution much much better as doing it this way was not general enough and not maintainable. |
No description provided.