Added module to ignored node modules list

[dotansimha]

Some dependencies (or dependencies of dependencies) might try to load module module, and it breaks CRA apps (such as https://github.com/sindresorhus/resolve-from) because Webpack can't find this module.

This PR adds module to list of empty node modules.

[Timer]

How is resolve-from used in the Browser? Can you provide a more concrete example please?

[dotansimha]

@Timer , it's not actually, it's a dependency of dependency.
For example, graphql-import package can be loaded on client side, which loads import-from, which loads resolve-from, and the module is loaded.

[jberney]

Another library using module is source-map-support. My CRA project is using source-map-support because:

info Reasons this module exists
   - Hoisted from "react-scripts#terser-webpack-plugin#terser#source-map-support"
   - Hoisted from "react-scripts#jest#jest-cli#jest-runner#source-map-support"
...
=> Found "babel-register#[email protected]"
info This module exists because "babel-core#babel-register" depends on it.

It looks like source-map-support put the attempt to load module in a try/catch, so it doesn't break my CRA app. But it does cause a console warning both on load and after every hot reload, which can be sort of noisy.

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[dotansimha]

@Timer ? someone?

[mrmckeb]

@dotansimha The CI issues should be resolved now, can you please rebase? Then I can merge this in. Thanks!

[dotansimha]

@mrmckeb done :)

[mrmckeb]

OK, I've merged this in. It's very low risk, but I'll keep a lookout for any potentially related new issues.