Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'getting started' link to 'docs' #5806

Merged

Conversation

kulek1
Copy link
Contributor

@kulek1 kulek1 commented Nov 14, 2018

@TryingToImprove pointed out that Getting started link might be misleading for new users who are looking for docs. I've changed Getting started to just Docs in the top of the navigation.

It's been mentioned here: #5753

@iansu
Copy link
Contributor

iansu commented Nov 14, 2018

I agree that having all the docs under "Getting Started" is confusing but I'm not sure if this is the right solution to that. I think ideally we'd want both "Getting Started" and "Docs" in the navigation. Getting Started would just be the tutorial and Docs would be the rest of the documentation.

@ianschmitz
Copy link
Contributor

Good point @iansu.

We were looking to align with React/Jest homepages, as it appears they follow this convention. I think we'd have to probably re-organize our documentation to do what you propose?

@iansu
Copy link
Contributor

iansu commented Nov 14, 2018

If we had to pick one title I think "Docs" would be the best choice. I was looking at the React docs and they have "Docs" and "Tutorial". However, our Getting Started section isn't really a standalone tutorial. Given all that I think this PR is probably fine as is.

@ianschmitz ianschmitz merged commit 69babbb into facebook:master Nov 14, 2018
dardub added a commit to OffBase/create-react-app that referenced this pull request Nov 27, 2018
* upstream/master: (210 commits)
  Support setupTests.ts (facebook#5698)
  Remove unnecessary whitespace in template HTML
  Run prettier on HTML files (facebook#5839)
  Some Grammar fixes (facebook#5858)
  Fix link to page about running tests (facebook#5883)
  fix: make typescriptformatter support 0.5 of fork checker (facebook#5879)
  Always test with the latest stable Node version on Travis (facebook#5546)
  Fix propertyDecorator test
  Upgrade babel deps
  Fix annotated var test
  Fix TypeScript decorator support (facebook#5783)
  fix: add `sideEffects: false` to react-error-overlay (facebook#5451)
  Add allowESModules option to babel-preset-react-app (facebook#5487)
  Make named-asset-import plugin work with export-as syntax (facebook#5573)
  React native repository updated in README.md (facebook#5849)
  extra polyfills must be included manually (facebook#5814)
  Rename 'getting started' link to 'docs' (facebook#5806)
  docs: Simplify installing Storybook with npx (facebook#5788)
  Don't polyfill fetch for Node -- additional files (facebook#5789)
  docs: Change Storybook install documentation (facebook#5779)
  ...
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants