feat: Add --no-open-browser cli option

[timmarinin]

This option allows to inhibit creating new browser tab/window.

[ghost]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

[ghost]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[gaearon]

Can you please describe your use case for this? Is it just a matter of personal taste, or is opening a new tab not working in some way for you?

[timmarinin]

It's a mix of both.

It falls back to xdg-open at my local machine, so it opens new tab in default browser, which I use for personal stuff. However, I keep development stuff in another browsers. So when I start dev server, it's a nuisance to have another tab pop out. Sometimes I want to keep distractions out, so I close my default browser. Nonetheless, react-scripts opens it back when I do npm start, which is kind of slow.

Another case is that sometimes I develop on remote virtual machine via ssh. That machine doesn't have X installed at all.

[gaearon]

Another case is that sometimes I develop on remote virtual machine via ssh. That machine doesn't have X installed at all.

What happens? Does opn fail? Hang?

[timmarinin]

Just noticed something strange: running react-scripts start created a bunch of
[some_hash].json.gzip in my project directory, but I don't think it's related to this issue.

Sometimes react-scripts process dies without any explanation/error. This is
happening in remote dev scenario. I'll investigate if this is related to opn.

[timmarinin]

json.gzip issue has been dealt with already, as far as I can see.

If you think that this PR introduced flag doesn't worth it (CONTRIBUTING.md says about minimizing flags), feel free to close the PR.

[gaearon]

I think we may revisit this at some point, but not now. Rather than add ad-hoc flags, I would like to wait for more feature requests, and then perhaps consolidate them into some sort of preferences. Thanks for your time!