Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service-Worker header to checkValidServiceWorker #6753

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

darthmaim
Copy link
Contributor

This PR adds the http header Service-Worker: script to the checkValidServiceWorker request in both serviceWorker templates, to match the spec on how to request a service worker.


See https://w3c.github.io/ServiceWorker/#update-algorithm:

To perform the fetch given request, run the following steps:

  1. Append Service-Worker/script to request’s header list.

And https://w3c.github.io/ServiceWorker/#service-worker-script-request:

An HTTP request to fetch a service worker's script resource will include the following header:

  • Service-Worker
    Indicates this request is a service worker's script resource request.

@stale
Copy link

stale bot commented May 4, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 4, 2019
@iansu iansu closed this May 4, 2019
@iansu iansu reopened this May 4, 2019
@bugzpodder bugzpodder added this to the 3.2 milestone Aug 11, 2019
@iansu iansu merged commit ea34c1d into facebook:master Oct 23, 2019
@iansu
Copy link
Contributor

iansu commented Oct 23, 2019

Thanks!

@darthmaim darthmaim deleted the feature/service-worker-header branch October 24, 2019 07:32
@lock lock bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants