Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax ESLint version range #6840

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Relax ESLint version range #6840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a2dba7
Relax eslint version range
ianschmitz Apr 18, 2019
d16a225
Use semver package to compare versions
ianschmitz Apr 18, 2019
f2c9dc4
Cleanup package.json files whitespace
ianschmitz Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/babel-plugin-named-asset-import/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "0.3.1",
"description": "Babel plugin for named asset imports in Create React App",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/babel-plugin-named-asset-import"
},
"license": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions packages/babel-preset-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "7.0.2",
"description": "Babel preset used by Create React App",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/babel-preset-react-app"
},
"license": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions packages/confusing-browser-globals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"test": "jest"
},
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/confusing-browser-globals"
},
"keywords": [
Expand Down
6 changes: 3 additions & 3 deletions packages/create-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
],
"description": "Create React apps with no build configuration.",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/create-react-app"
},
"license": "MIT",
Expand All @@ -33,7 +33,7 @@
"fs-extra": "7.0.1",
"hyperquest": "2.1.3",
"inquirer": "6.2.2",
"semver": "5.6.0",
"semver": "6.0.0",
"tar-pack": "3.4.1",
"tmp": "0.0.33",
"validate-npm-package-name": "3.0.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-config-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "3.0.8",
"description": "ESLint configuration used by Create React App",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/eslint-config-react-app"
},
"license": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-app-polyfill/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "0.2.2",
"description": "Polyfills for various browsers including commonly used language features",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/react-app-polyfill"
},
"license": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions packages/react-dev-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "8.0.0",
"description": "Webpack utilities used by Create React App",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/react-dev-utils"
},
"license": "MIT",
Expand Down
6 changes: 3 additions & 3 deletions packages/react-error-overlay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"build:prod": "cross-env NODE_ENV=production node build.js"
},
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/react-error-overlay"
},
"license": "MIT",
Expand Down Expand Up @@ -44,7 +44,7 @@
"chalk": "^2.4.2",
"chokidar": "^2.1.2",
"cross-env": "5.2.0",
"eslint": "5.16.0",
"eslint": "^5.16.0",
"eslint-config-react-app": "^3.0.8",
"eslint-plugin-flowtype": "2.50.1",
"eslint-plugin-import": "2.16.0",
Expand Down
7 changes: 4 additions & 3 deletions packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "2.1.8",
"description": "Configuration and scripts for Create React App.",
"repository": {
"type" : "git",
"url" : "https://github.com/facebook/create-react-app.git",
"type": "git",
"url": "https://github.com/facebook/create-react-app.git",
"directory": "packages/react-scripts"
},
"license": "MIT",
Expand Down Expand Up @@ -41,7 +41,7 @@
"css-loader": "2.1.1",
"dotenv": "6.2.0",
"dotenv-expand": "4.2.0",
"eslint": "5.16.0",
"eslint": "^5.16.0",
"eslint-config-react-app": "^3.0.8",
"eslint-loader": "2.1.2",
"eslint-plugin-flowtype": "2.50.1",
Expand Down Expand Up @@ -70,6 +70,7 @@
"react-dev-utils": "^8.0.0",
"resolve": "1.10.0",
"sass-loader": "7.1.0",
"semver": "6.0.0",
"style-loader": "0.23.1",
"terser-webpack-plugin": "1.2.3",
"url-loader": "1.1.2",
Expand Down
3 changes: 2 additions & 1 deletion packages/react-scripts/scripts/utils/verifyPackageTree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

const chalk = require('react-dev-utils/chalk');
const fs = require('fs');
const semver = require('semver');
const path = require('path');

// We assume that having wrong versions of these
Expand Down Expand Up @@ -74,7 +75,7 @@ function verifyPackageTree() {
fs.readFileSync(maybeDepPackageJson, 'utf8')
);
const expectedVersion = expectedVersionsByDep[dep];
if (depPackageJson.version !== expectedVersion) {
if (!semver.satisfies(depPackageJson.version, expectedVersion)) {
console.error(
chalk.red(
`\nThere might be a problem with the project dependency tree.\n` +
Expand Down