Fix the e2e test #699
Merged
Fix the e2e test #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the end-to-end test, we want to test all the latest packages from the monorepo instead of the versions from npm. To do this we will now: * run `lerna bootstrap` in the repo root folder before packaging react-scripts * bundle the deps like we do for releases, so the e2e test uses those packages
|
OK, let’s give it a try. Thanks! |
ghost
added
the
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
* Fix the e2e test In the end-to-end test, we want to test all the latest packages from the monorepo instead of the versions from npm. To do this we will now: * run `lerna bootstrap` in the repo root folder before packaging react-scripts * bundle the deps like we do for releases, so the e2e test uses those packages * Fix copy-pasted comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end-to-end test, we want to test all the latest packages from
the monorepo instead of the versions from npm.
To do this we will now:
lerna bootstrapin the repo root folder before packaging react-scripts