Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard polyfills against window possibly being undefined #7205

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

jxom
Copy link
Contributor

@jxom jxom commented Jun 12, 2019

Hello!

This PR is just a small one, and ensures that window is not undefined before it invokes the polyfill.

packages/react-app-polyfill/ie9.js Outdated Show resolved Hide resolved
@ianschmitz ianschmitz modified the milestones: 3.1, 3.2 Aug 9, 2019
@ianschmitz ianschmitz modified the milestones: 3.2, 3.1.3 Sep 24, 2019
@ianschmitz ianschmitz closed this Sep 24, 2019
@ianschmitz ianschmitz reopened this Sep 24, 2019
@ianschmitz ianschmitz changed the title Guard ie9 polyfill against window possibly being undefined Guard polyfills against window possibly being undefined Sep 24, 2019
@ianschmitz ianschmitz merged commit b1e6155 into facebook:master Sep 24, 2019
@lock lock bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants