Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostCSS plugins support #8331

Closed
wants to merge 6 commits into from
Closed

PostCSS plugins support #8331

wants to merge 6 commits into from

Conversation

pavinthan
Copy link
Contributor

@pavinthan pavinthan commented Jan 17, 2020

This PR created after discustion about "PostCSS plugins support" in https://spectrum.chat/create-react-app/general/postcss-plugins-support~819b4e89-ea77-4010-86d4-dd82b4fa33e6?m=MTU3NDA5NTgwODc5NA==

Can you raise a PR for adding this in? We would be open to discuss PostCSS plugin support - but not full Webpack support at this stage.

@mrmckeb may you please have a look into this PR?

@elektronik2k5
Copy link

This is great! I believe this also needs to be documented.

@gael-boyenval
Copy link

This would be awesome 😎

dustinsoftware added a commit to dustinsoftware/create-react-app that referenced this pull request Feb 13, 2020
This is accomplished via postcss.config.js, which will be searched for if `plugins` is not specified as an option to `postcss-loader`

Postcss plugins are required to use Tailwind CSS, a popular styling framework which leverages a custom module import syntax.

This overlaps slightly with facebook#8331, but takes a non-breaking change approach.
@pavinthan
Copy link
Contributor Author

pavinthan commented Feb 26, 2020

Hi @iansu, @amyrlam, @mrmckeb, @ianschmitz and @petetnt,

This PR updated with

  1. There are no default config files in templates.
  2. Apply default config if any PostCSS config files not exist
    • (Added cosmiconfig to check config file exist).
  3. Docs also updated - Post-Processing CSS

Please have a look into this PR,
Thanks.

@stale
Copy link

stale bot commented Mar 27, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 27, 2020
@elektronik2k5
Copy link

Not stale. People are busy.

@stale stale bot removed the stale label Mar 28, 2020
@pavinthan pavinthan closed this Apr 14, 2020
@pavinthan pavinthan reopened this Apr 14, 2020
@stale
Copy link

stale bot commented May 15, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 15, 2020
@pavinthan pavinthan closed this May 16, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants