do not mutate translation input args

facebook · Feb 16, 2023 · c44511d · c44511d
1 parent b629694
commit c44511d
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/packages/docusaurus-theme-classic/src/translations.ts b/packages/docusaurus-theme-classic/src/translations.ts
@@ -68,11 +68,12 @@ function translateNavbar(
     return navbar;
   }
 
-  const {logo} = navbar;
-
-  if (logo) {
-    logo.alt = navbarTranslations[`logo.alt`]?.message ?? navbar.logo?.alt;
-  }
+  const logo = navbar.logo
+    ? {
+        ...navbar.logo,
+        alt: navbarTranslations[`logo.alt`]?.message ?? navbar.logo?.alt,
+      }
+    : undefined;
 
   return {
     ...navbar,
@@ -184,11 +185,12 @@ function translateFooter(
 
   const copyright = footerTranslations.copyright?.message ?? footer.copyright;
 
-  const {logo} = footer;
-
-  if (logo) {
-    logo.alt = footerTranslations[`logo.alt`]?.message ?? footer.logo?.alt;
-  }
+  const logo = footer.logo
+    ? {
+        ...footer.logo,
+        alt: footerTranslations[`logo.alt`]?.message ?? footer.logo?.alt,
+      }
+    : undefined;
 
   return {
     ...footer,