Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static files in blog/assets is not working #1114

Closed
tconnally opened this issue Nov 15, 2018 · 1 comment
Closed

Static files in blog/assets is not working #1114

tconnally opened this issue Nov 15, 2018 · 1 comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@tconnally
Copy link

📚 Documentation

The following location location in the docs indicates what is possibly an incorrect procedure for adding graphics to a blog post. It says to create an "assets" folder in the /blog directory. This is apparently not working, and graphics should apparently live in /static/img, and use a path of /img/image-name.png. But this didn't seem to work in the testing I just did.

https://docusaurus.io/docs/en/doc-markdown#linking-to-images-and-other-assets

Have you read the Contributing Guidelines on issues?

(yes.
@endiliey endiliey changed the title Location of graphics for blog posts might be incorrect Static files in blog/assets is not working Nov 21, 2018
@endiliey endiliey added bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. labels Nov 21, 2018
@endiliey
Copy link
Contributor

We should replace all string occurrences of assets/XXX in all blog markdown just like in docs

Notice how we replace it in docs.js but not in blog.js

https://github.com/facebook/Docusaurus/blob/beca1697ffe733b1c13caacc4189e25264c828a2/v1/lib/server/docs.js#L128-L129

https://github.com/facebook/Docusaurus/blob/beca1697ffe733b1c13caacc4189e25264c828a2/v1/lib/server/docs.js#L108-L119

server/blog.js
We should modify the content at this line
https://github.com/facebook/Docusaurus/blob/beca1697ffe733b1c13caacc4189e25264c828a2/v1/lib/server/blog.js#L59

tsmrachel added a commit to tsmrachel/Docusaurus that referenced this issue Dec 6, 2018
@tsmrachel
fix: facebook#1114 static files in blog/assets is not working
1386bf0
@tsmrachel tsmrachel mentioned this issue Dec 6, 2018
Merged
@endiliey endiliey mentioned this issue Dec 7, 2018
Closed
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
@NikolayS NikolayS mentioned this issue Dec 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endiliey @tconnally