Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): <Admonition> should render properly without heading/icon #10080

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

andrmaz
Copy link
Contributor

@andrmaz andrmaz commented Apr 26, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

closes #8568

Test Plan

Admonition example

Test links

https://deploy-preview-10080--docusaurus-2.netlify.app/tests/pages/markdown-tests-mdx/#admonitions

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @andrmaz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Apr 26, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 18ad488
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/662cf494119bef0008edc149
😎 Deploy Preview https://deploy-preview-10080--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 26, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 58 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 58 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 71 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 26, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@andrmaz
Copy link
Contributor Author

andrmaz commented Apr 27, 2024

I need to fix the markdown test. I'm on it

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Apr 30, 2024
@slorber slorber changed the title feat: display admonition without heading fix: <Admonition> should render properly without heading/icon Apr 30, 2024
@slorber slorber changed the title fix: <Admonition> should render properly without heading/icon fix(theme): <Admonition> should render properly without heading/icon Apr 30, 2024
@slorber slorber merged commit c967ea5 into facebook:main Apr 30, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admonitions: hide header (icon and title)
3 participants