Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): SearchPage should respect contextualSearch: false setting #10178

Merged
merged 3 commits into from
May 30, 2024

Conversation

ncoughlin
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Getting the Search page working for anyone without facets configured on Algolia index.

Related issues/PRs

#3805

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 29, 2024
Copy link

netlify bot commented May 29, 2024

[V2]

Name Link
🔨 Latest commit f8b0e90
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66585b9ee3576500080f9c54
😎 Deploy Preview https://deploy-preview-10178--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 29, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 62 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 69 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label May 30, 2024
@slorber slorber changed the title SearchPage now respects contextualSearch setting fix(theme): SearchPage should respect contextualSearch: false setting May 30, 2024
@slorber
Copy link
Collaborator

slorber commented May 30, 2024

Thanks

This is already an improvement, but this alone does not totally fix #3805

searchParameters.facetFilters remains unused on the search page, and it's a bit annoying to fix because historically we use the algoliaSearchHelper which takes attributes in another shape. I'd like to get rid of this helper in the future but this requires some refactor.

@slorber slorber merged commit 1049294 into facebook:main May 30, 2024
33 checks passed
@ncoughlin ncoughlin deleted the patch-3 branch May 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants