fix: throw error when forgot to pass in GIT_USER #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 04e6f53 |
yangshun
changed the title
yangshun
approved these changes
Oct 14, 2018
There was a problem hiding this comment.
Thanks @tanhauhau! In future you don't have to put the issue number in the commit message, because GitHub automatically adds this PR number to the message when it gets merged and seeing two issue numbers in the message is confusing.
Putting "Closes #XXX" in the PR summary is sufficient. Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1025
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs