-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translations): change casing of some en labels #10394
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
I think this has been done this way historically on purpose. Not sure we are willing to change that right now, considering all those labels can be overridden by users and nobody complained so far about the defaults. @Josh-Cena I'm sure you have an opinion on this 😄 |
I don't remember this ever being a conscious decision (and even if there was, it predated me since most of these are ancient features). That said, I'm +1 on this change to use sentence-case everywhere. |
Ok let's merge this then, and hope users wont complain about the change. In case you want to restore former behavior:
|
Pre-flight checklist
Motivation
Some strings don't seem to match the overall semantics of Docusaurus. This PR aims to correct the given translation strings by converting them from pascal case to normal capitalization. Please correct me if this was done intentionally.