refactor(v2): simplify blog truncate function #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: polish
|
Deploy preview for docusaurus-2 ready! Built with commit 1cb4939 |
|
Deploy preview for docusaurus-preview ready! Built with commit 1cb4939 |
lex111
reviewed
Nov 12, 2019
Co-Authored-By: Alexey Pyltsyn <[email protected]>
lex111
approved these changes
Nov 12, 2019
wgao19
reviewed
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simplify blog truncate function. This should be faster because we're passing
limitto split function and less code to execute lolHave you read the Contributing Guidelines on pull requests?
yes
Test Plan
Edit blog file
With truncate marker, read more still showed
Without truncate marker, show all
