Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix syntax highlighting for YML code blocks #1988

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 13, 2019

Motivation

Some blocks of code with YML are marked as Markdown-code, which is incorrect and needs to be fixed.

Have you read the Contributing Guidelines on pull requests?

Yes

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 13, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 1b8d4c1

https://deploy-preview-1988--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 1b8d4c1

https://deploy-preview-1988--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of that was intentional because the markdown highlighting looked nicer than the yml's. Anyway, I trust your judgement 😄

@yangshun yangshun merged commit 472a1a6 into facebook:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants