-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(v2): improve markup of code blocks #2056
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 854f8a0 |
Deploy preview for docusaurus-preview ready! Built with commit 854f8a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that this improve things a little bit compared to #2048.
Can we somehow resolve the layout style ?
I kinda dislike the fact that there is a scrollbar now for https://deploy-preview-2056--docusaurus-2.netlify.com/docs/markdown-features
Previously it was like this (before #2048 )
Uh, yes, that’s bad :( |
I will review in more detail over the Thanksgiving long weekend. The new version is not released yet so it can wait a bit. Thanks for catching it Endi! |
As I see the issue: we need to somehow limit the width of the container with block code, how to do this? This is not so difficult considering the following code, but it will not work because value is presented as a percentage :(
Turns out you need to somehow get rid of the percent sign, but this is impossible (???), so the only option for me is to use hard-coded value (75 = parent col width), it's not very good at all, but I have no more ideas how to fix it. 😢 |
@lex111 I think we can revert #2048 with #2071 and then attempt to remove the autowrap again in new PR. What do you think ? Since we don't have a perfect solution yet. I think its also very tied to infima variables css (that might change somehow). I have limited knowledge of infima although I have access to the repo, maybe @yangshun want to give @lex111 access to the repo? |
I actually was waiting for the @yangshun review these days, because this is a rather difficult case and there is probably a better solution. |
Let's wait then. |
Motivation
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See markup, no UI changes.