fix(v2): align GH button in vertical center #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: maintenance
|
Deploy preview for docusaurus-preview ready! Built with commit 182f254 |
|
Deploy preview for docusaurus-2 ready! Built with commit 182f254 |
yangshun
approved these changes
Dec 12, 2019
|
what is the difference ? 🤧 and btw seems that the 2.0.0-alpha.39 is cut |
|
The difference is that now the GH button is aligned vertically exactly in the center. Try to open these links in separate tabs and you will see the difference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I can’t pass by and not fix this annoying flaw! (just kidding 😃 ).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan