Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add Sass/SCSS under the styling section #2423

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

rlamana
Copy link
Contributor

@rlamana rlamana commented Mar 18, 2020

Motivation

For those looking for Sass/SCSS support and to show how modular v2 is ;), I added a small section to the styling section on how to use Sass with docusaurus v2 via the unofficial plugin I created.

Have you read the Contributing Guidelines on pull requests?

Yes.

@rlamana rlamana requested a review from yangshun as a code owner March 18, 2020 10:23
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 18, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 18, 2020

Deploy preview for docusaurus-2 ready!

Built with commit e558ad6

https://deploy-preview-2423--docusaurus-2.netlify.com

@yangshun
Copy link
Contributor

Master is broken because of me. I'll fix it tonight, sorry about that.

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 21, 2020
@yangshun
Copy link
Contributor

yangshun commented Mar 23, 2020

Would you also mind adding your plugin to https://v2.docusaurus.io/docs/next/resources in a separate PR?

@rlamana
Copy link
Contributor Author

rlamana commented Mar 23, 2020

@yangshun I added the plugin here: #2446

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thank you!

@yangshun yangshun merged commit c05cb75 into facebook:master Mar 23, 2020
@yangshun yangshun changed the title docs(v2): add Sass/SCSS in docs under the styling section docs(v2): add Sass/SCSS under the styling section Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants