-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): add Sass/SCSS under the styling section #2423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for docusaurus-2 ready! Built with commit e558ad6 |
Master is broken because of me. I'll fix it tonight, sorry about that. |
lex111
suggested changes
Mar 18, 2020
website/versioned_docs/version-2.0.0-alpha.48/styling-layout.md
Outdated
Show resolved
Hide resolved
lex111
added
the
pr: documentation
This PR works on the website or other text documents in the repo.
label
Mar 21, 2020
Would you also mind adding your plugin to https://v2.docusaurus.io/docs/next/resources in a separate PR? |
yangshun
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thank you!
yangshun
changed the title
docs(v2): add Sass/SCSS in docs under the styling section
docs(v2): add Sass/SCSS under the styling section
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: documentation
This PR works on the website or other text documents in the repo.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For those looking for Sass/SCSS support and to show how modular v2 is ;), I added a small section to the styling section on how to use Sass with docusaurus v2 via the unofficial plugin I created.
Have you read the Contributing Guidelines on pull requests?
Yes.