fix(v2): improve code block scroll accessibility #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
commented
Mar 29, 2020
| @@ -117,6 +119,7 @@ export default ({children, className: languageClassName, metastring}) => { | |||
| {showCopied ? 'Copied' : 'Copy'} | |||
| </button> | |||
| <pre | |||
| tabIndex="0" | |||
There was a problem hiding this comment.
We could add this attribute to the div element with codeBlockLines class, but then the outline is poorly visible, so I added it to the pre tag and disabled the corresponding ESLint rule.
|
Deploy preview for docusaurus-2 ready! Built with commit e63c166 |
yangshun
approved these changes
Mar 29, 2020
yangshun
force-pushed
the
lex111/a11y-scrollable-code-block
branch
from
ed1d5a6
to
e63c166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refers to #2403
This ensures that this scrollable region has keyboard access.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
tabbutton to jump to code block.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)