misc: add instructions about test release #2486
Conversation
lex111
added
the
pr: maintenance
|
Deploy preview for docusaurus-2 ready! Built with commit ea4848e |
...ges/docusaurus-plugin-content-blog/src/__tests__/__snapshots__/generateBlogFeed.test.ts.snap
Outdated
Show resolved
Hide resolved
lex111
force-pushed
the
lex111/test-release
branch
from
e8df897
to
a29bf9f
Compare
|
It looks like the Verdaccio dependencies in the root workspace affect the rest of the dependencies (including v1). Can we use Docker to run a private proxy? |
|
I don't think we have time to get this working before our next release |
|
Sure, it can wait. I think it's best to use Docker here. |
…into lex111/test-release
|
I updated the instructions, now we only need to execute one command (but Docker installed is required). It is OK? |
|
Yeah sure thing
…On Wed, Apr 1, 2020, 7:30 PM Alexey Pyltsyn ***@***.***> wrote:
I updated the instructions, now we only need to execute one command (but
Docker installed is required). It is OK?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2486 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKBCHP4CXETZNXX4FMH3RLRKMQT5ANCNFSM4LXRQ7BA>
.
|
lex111
force-pushed
the
lex111/test-release
branch
from
4ecd256
to
798a9b7
Compare
lex111
force-pushed
the
lex111/test-release
branch
from
798a9b7
to
df6e6a6
Compare
|
@yangshun ready for review! |
|
Of course! |
|
I think you can easily googled installation instructions for Docker, especially as this sort information may change over time. |
|
I don't mean the installation instructions. Just mention that we need Docker installed. Because it's not obvious from the instructions unless I read the script. |
|
Ah sure, added this to the heading. |
Motivation
Reduce the possibility of releasing a "bad" version that will make us hurry and nervously fix it as a hot fix :(
The point is a simple one: before the release of the new version, we build all the packages and try to run the website with them. To make everything as close to reality as possible, we publish the packages in a local private npm registry Verdaccio and only then use them for testing purposes.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See instructions. Tested on Linux, but should work on Mac.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)