Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add rounded corners in code blocks properly #2533

Merged
merged 1 commit into from
Apr 5, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 5, 2020

Motivation

The rounded corners in the code blocks must be set to non-scrollable containers of code blocks, otherwise they will not be visible when scrolling.

image

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 5, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 5, 2020
@lex111 lex111 requested a review from yangshun April 5, 2020 07:19
@lex111 lex111 requested a review from wgao19 as a code owner April 5, 2020 07:19
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 5, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 32b63d5

https://deploy-preview-2533--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is great. Thanks for catching

@yangshun yangshun merged commit 7bc7241 into master Apr 5, 2020
@yangshun yangshun deleted the lex111/round-code-blocks branch April 5, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants