refactor(v2): use nav link component only where needed #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
added
the
pr: polish
|
Deploy preview for docusaurus-2 ready! Built with commit a40a9f7 |
yangshun
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in #2580 (comment), this will allow clean things up with nav links, in other words, it’s now clearer where we need to use the functionality of nav links, in their original purpose*.
This basically removes unnecessary DOM attrs related with highlighting (via CSS) the current link (for our needs, this is only necessary for navbar and doc sidebar).
This is potentially BC change, although it seems unlikely that anyone used this functionality, especially since it would not work by default except in the navbar and doc sidebar (because the according CSS styles for the active menu item are defined only for these specified components).
And in general, it is not clear where this can be useful to the end user, so this is absolutely unnecessary functionality for them.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)