fix(v2): use remark-admonitions separately in each plugin instead of in preset only #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 67d7685 |
yangshun
approved these changes
Apr 22, 2020
…usaurus into lex111/decouple-admonitions
lex111
force-pushed
the
lex111/decouple-admonitions
branch
from
2d3c192
to
67d7685
Compare
yangshun
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR decouples admonitions from the classic theme and preset to resolve #2525.
Now admonitions is included for each of the two plugins separately (docs and blog), this produces some duplication of code, but the classic theme is not related with admonitions.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Admonitions should work as earlier, since the
admonitionsoptions in preset passed to each plugin.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)