docs(v2): add require.resolve to plugin imports on remaining pages #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 05caea5 |
yangshun
approved these changes
Jun 16, 2020
slorber
added
the
pr: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Plugin imports on some pages are not wrapped in
require.resolveyet.This PR adds
require.resolveto plugin imports on the remaining pages (for v2.0.0-alpha.56 docs).Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
The changes can be viewed on Netlify here:
https://deploy-preview-2946--docusaurus-2.netlify.app/
Related PRs
This PR is similar to #2941, but for the remaining pages.