Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): change description for blog post paginator #3029

Merged

Conversation

teikjun
Copy link
Contributor

@teikjun teikjun commented Jul 7, 2020

Motivation

This PR closes #2698. Originally, "Next Post" links to an older blog post and "Previous Post" links to a newer blog post. This PR changes the description to "Older Post" and "Newer Post" respectively to avoid confusion.

I noticed that blog list paginator has "Older Entries" on the right hand side, so I kept the same ordering for blog page paginator.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

The changes can be viewed at https://deploy-preview-3029--docusaurus-2.netlify.app/blog/2018/12/14/Happy-First-Birthday-Slash
image

@teikjun teikjun requested a review from lex111 as a code owner July 7, 2020 13:44
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 7, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 3939e7e

https://deploy-preview-3029--docusaurus-2.netlify.app

@slorber slorber merged commit e5afd18 into facebook:master Jul 8, 2020
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] The blog posts order is wrong
4 participants