-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): notify users when docusaurus version is outdated #3032
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 4dc8560 |
Hey @teikjun how do you test this exactly?
does not exist (bad release) and
I get: |
Hi @slorber |
Thanks @teikjun It seems to almost work, but not on the 1st run of the update notifier for this package. You can clear its cache on macos with the following command:
Can you ensure it works fine on the first run too? |
It works on the first run now! The testing instructions are similar to before :) |
thanks! |
Motivation
Notify the user when their @docusaurus/core version is outdated.
The interval between notifications is set to one day so that it is not too naggy.
This PR closes #2199.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan (edited)
yarn install
in the root directorypackage.json
file in/packages/docusaurus
, change line 4 to"version": "2.0.0-alpha.56",
/website
directory in your terminal, runyarn start
. You should see a notification like the one below!yarn start
again, there should be no notification this time because the interval is set to one dayAdditional Remarks
The notify method of update-notifier does not work directly with our docusaurus command, so the implementation needed to be modified.