Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): Support keywords meta in blog posts #3038

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

dpkg
Copy link
Contributor

@dpkg dpkg commented Jul 8, 2020

Motivation

I was looking forward to have this feature work on my personal website which i built using docusaurus.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

image
Can be easily verified by checking the html head element (searching the keywords meta tag). Check the highlighted element in the screenshot (towards the bottom).

Related PRs

NA

@dpkg dpkg requested review from lex111 and yangshun as code owners July 8, 2020 21:51
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit ccd5957

https://deploy-preview-3038--docusaurus-2.netlify.app

@dpkg dpkg changed the title Support keywords meta in blog posts Support keywords meta in blog posts #3036 Jul 8, 2020
@dpkg dpkg changed the title Support keywords meta in blog posts #3036 #3036 Support keywords meta in blog posts Jul 8, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 8, 2020
@slorber
Copy link
Collaborator

slorber commented Jul 9, 2020

Thanks

The doc you refer to is related to the docs plugin. Each plugin handle markdown the way it wants, and use the frontmatter it wants. We had keywords for docs, not for blogs, so it's fine to have it for both.

However I'm not very convinced that keywords are still useful for SEO reasons

@slorber slorber changed the title #3036 Support keywords meta in blog posts feat(v2): Support keywords meta in blog posts Jul 9, 2020
@slorber slorber linked an issue Jul 9, 2020 that may be closed by this pull request
@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Jul 9, 2020
@slorber slorber merged commit 04fc419 into facebook:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown header keywords should render meta tag for blog post pages
4 participants