-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): add notifications for commands #3074
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 2fba092 |
I find notification a bit annoying. Maybe adding config to disable it might be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Some persons might like such notifications but it's not the case for all users.
I'd rather have this feature being an opt-in feature, that you can enable with a configuration setting (that would be documented, and false by default).
@taylorallen0913 tell me if you are interested to update the PR, and making this feature optional. |
I would be willing to continue this feature, but I am not sure what config you are intending to hold this in. Where would you suggest putting the setting? |
I think adding a flag to each command is a good place. |
I'd rather have a notification: true/false (false by default) in site config than a new cli option. People can use env variables if they want it to be dynamic anyway. |
Hi @taylorallen0913 , I'm closing for now but if you want to do the changes I'll re-open |
Motivation
I found this really cool library for dealing with notifications, so I thought why not implement it here. I've implemented notifications for
start
,swizzle
,build
, anddeploy
so far.Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Start:
Swizzle:
Build:
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)