-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): removed duplicate text under "Using React" section #3201
Conversation
Hi @Boosh511! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Deploy preview for docusaurus-2 ready! Built with commit 398483f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Is this problem present in the other versions? Could you help to check and remove if possible?
problem doesn't seem present in any version before alpha 61 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have to edit the docs within website/docs
as well. The problem exists on the trunk version of docs - https://deploy-preview-3201--docusaurus-2.netlify.app/build/docs/next/creating-pages
Lastly, please sign the CLA so I can merge this PR after you make the changes in website/docs/creating-pages.md
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
should be all good 👍 |
Tnanks, looks like a recent mistake I did :) |
Motivation
duplicate text found in "Using React" section of creating-pages doc. very tiny fix.
as its very small, perhaps expand this section or remove entirely and put these sentences elsewhere?
Have you read the Contributing Guidelines on pull requests?
yep 👍