-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): docusaurus start --poll 500 should work + better config load failure error #3622
Conversation
…ir is wrongly passed as a cli arg and lead to config loading failure
Deploy preview for docusaurus-2 ready! Built with commit a9ef52c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update our docs some more.
https://v2.docusaurus.io/docs/cli/#options
Yes, that will be enough. |
Motivation
Fixes #3620
docusaurus start --poll 500
should accept 500 as poll interval valueAlso we should use polling for both webpack dev server and chokidar file watchers
Also improve the error message in such weird case so that user can understand we try to load the config from
500/docusaurus.config.js
and that 500 is interpreted as the cli siteDir arg.Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Local test and checking the correct args are forwarded to Webpack config