-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): update Client API docs page #3835
docs(v2): update Client API docs page #3835
Conversation
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 4159983 |
e8e8e08
to
10bf8bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using special comments (like highlight-next-line
, highlight-start
, and highlight-end
) for syntax highlighting? https://v2.docusaurus.io/docs/markdown-features/#line-highlighting
This is a more flexible approach.
I think it depends on the use-case, current approach might be more useful (less cluttering) for example, for highlighting single line. In this PR I have just followed the current style used on the docs page, but I will consider using the syntax you have suggested in the future. |
Fair enough. Before merge, let's just change the order follow of the method signatures to ensure consistency again. I mean, do it by analogy as for |
thanks :) |
Motivation
This PR updates the
Docusaurus Client API
page and includes following changes:const
instead offunction
,usePluginData
anduseAllPluginInstancesData
hooks, this improves the readability of ToCHave you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Changes have been tested on Docusuaurs V2 website locally.
Related PRs
No.