Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): clean-ups and fixes #4244

Merged
merged 1 commit into from
Feb 18, 2021
Merged

refactor(v2): clean-ups and fixes #4244

merged 1 commit into from
Feb 18, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Feb 18, 2021

Motivation

Small minor fixes:

  • Remove/optimize of redundant CSS properties.
  • Remove non-working CSS class name
  • Fix bug with hideable navbar (with multiple and fast scrolling at beginning of page, the navbar was incorrectly hidden)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 18, 2021
@lex111 lex111 requested a review from slorber as a code owner February 18, 2021 04:59
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 18, 2021
@netlify
Copy link

netlify bot commented Feb 18, 2021

[V1] Deploy preview success

Built with commit d19b10c

https://deploy-preview-4244--docusaurus-1.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 18, 2021

Size Change: +15 B (0%)

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 111 kB +15 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 18, 2021

Deploy preview for docusaurus-2 ready!

Built with commit d19b10c

https://deploy-preview-4244--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 18, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4244--docusaurus-2.netlify.app/classic/

@netlify
Copy link

netlify bot commented Feb 18, 2021

[V1] Deploy preview success

Built with commit 6f5c21a

https://deploy-preview-4244--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Feb 18, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 6f5c21a

https://deploy-preview-4244--docusaurus-2.netlify.app

@slorber slorber merged commit 75228c4 into master Feb 18, 2021
@lex111 lex111 deleted the lex111/cleanups branch February 19, 2021 18:20
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants