[DO-NOT-MERGE] RFC: use esbuild to significantly speedup building #4487
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,9 +17,10 @@ import webpack, { | |
| Stats, | ||
| } from 'webpack'; | ||
| import fs from 'fs-extra'; | ||
| // import TerserPlugin from 'terser-webpack-plugin'; | ||
| import {ESBuildMinifyPlugin} from 'esbuild-loader'; | ||
| // import OptimizeCSSAssetsPlugin from 'optimize-css-assets-webpack-plugin'; | ||
| // import CleanCss from 'clean-css'; | ||
| import path from 'path'; | ||
| import crypto from 'crypto'; | ||
| import chalk from 'chalk'; | ||
|
|
@@ -29,7 +30,7 @@ import { | |
| ConfigurePostCssFn, | ||
| PostCssOptions, | ||
| } from '@docusaurus/types'; | ||
| // import CssNanoPreset from '@docusaurus/cssnano-preset'; | ||
| import {version as cacheLoaderVersion} from 'cache-loader/package.json'; | ||
| import { | ||
| BABEL_CONFIG_FILE_NAME, | ||
|
|
@@ -143,11 +144,16 @@ export function getBabelOptions({ | |
|
|
||
| export function getBabelLoader( | ||
| isServer: boolean, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| babelOptions?: TransformOptions | string, | ||
| ): Loader { | ||
| return { | ||
| loader: require.resolve('esbuild-loader'), | ||
| options: { | ||
| loader: 'tsx', | ||
| format: isServer ? 'cjs' : 'esm', | ||
| target: 'es2017', | ||
| }, | ||
| }; | ||
| } | ||
|
Comment on lines
145
to
158
There was a problem hiding this comment. I plan to make this function be like if (process.env.ESBUILD) {
return {
loader: require.resolve('esbuild-loader'),
options: {
loader: 'tsx',
format: isServer ? 'cjs' : 'esm',
target: 'es2017',
},
};
return {
loader: require.resolve('babel-loader'),
options: getBabelOptions({isServer, babelOptions}),
}
}In this way all the existing code that uses the Do maintainers have any options? There was a problem hiding this comment.
|
||
|
|
||
|
|
@@ -463,6 +469,7 @@ export function getHttpsConfig(): boolean | {cert: Buffer; key: Buffer} { | |
| } | ||
|
|
||
| // See https://github.com/webpack-contrib/terser-webpack-plugin#parallel | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| function getTerserParallel() { | ||
| let terserParallel: boolean | number = true; | ||
| if (process.env.TERSER_PARALLEL === 'false') { | ||
|
|
@@ -476,74 +483,7 @@ function getTerserParallel() { | |
| return terserParallel; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| export function getMinimizer(useSimpleCssMinifier = false): Plugin[] { | ||
| return [new ESBuildMinifyPlugin({target: 'es2017', css: true})]; | ||
|
There was a problem hiding this comment. Wonder how much different this minification is compared to the old one? There was a problem hiding this comment. Earlier stat because I mess up the build shows that it reduces the output by 1%. |
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow esbuild doesn't like that the client files are not in esm, so I setup the script to compile the client files to esm.