fix(v2): i18n perf issue: getTranslationFile() should not load content again #4593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
i18n perf: the docs plugin read twice the markdown files, because it tries to load content again when trying to retrieve translation files to use.
Before, reloading the content that has already been loaded:
After: reusing the content that has already been loaded:
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Not sure how. It's hard to prevent a plugin author to call
this.loadContent()
anywhere and have a perf issue, including maintainers in core plugins. It's not performant but it works.