Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): emphasize subset of markdown supported languages #4725

Merged
merged 2 commits into from
May 4, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Too often people ask about Java / PHP syntax highlighting being not supported out-of-box (cr #4535, #4720). Although this is already specified in the documentation, I guess we can benefit from some more emphasis.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Related PRs

@netlify
Copy link

netlify bot commented May 4, 2021

[V2]

Built with commit c84be0d

https://deploy-preview-4725--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented May 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 85
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4725--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 4, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to make this even more visible :)

@slorber slorber changed the title doc(v2): emphasize subset of markdown supported languages docs(v2): emphasize subset of markdown supported languages May 4, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 4, 2021
@netlify
Copy link

netlify bot commented May 4, 2021

[V1]

Built with commit c84be0d

https://deploy-preview-4725--docusaurus-1.netlify.app

@slorber slorber merged commit ccf1a22 into facebook:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants