Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix encoding of markdown image/file inline file-loaders #4736

Merged
merged 7 commits into from
May 6, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 6, 2021

Motivation

Attempt to fix #4730

Errors may be related to using Windows, folders with a number, or Chinese filenames.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label May 6, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 6, 2021
@netlify
Copy link

netlify bot commented May 6, 2021

[V1]

Built with commit 67913b3

https://deploy-preview-4736--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented May 6, 2021

[V2]

Built with commit 67913b3

https://deploy-preview-4736--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented May 6, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 58
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4736--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented May 6, 2021

Size Change: 0 B

Total Size: 691 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 88.5 kB 0 B
website/build/assets/js/main.********.js 513 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 27.1 kB 0 B

compressed-size-action

@slorber slorber marked this pull request as ready for review May 6, 2021 14:29
@slorber slorber requested a review from lex111 as a code owner May 6, 2021 14:29
@slorber slorber merged commit a79c70c into master May 6, 2021
@slorber slorber deleted the slorber/escape-file-loader-paths branch August 17, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image file name can be in Chinese or other languages
2 participants