fix(v2): improve accessibility of code blocks #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V1] 🔨 Explore the source changes: 1d6d384 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60c21041718bab0007a37db2 😎 Browse the preview: https://deploy-preview-4943--docusaurus-1.netlify.app |
|
✔️ [V2] 🔨 Explore the source changes: 1d6d384 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c21041de5b640008ca3d7e 😎 Browse the preview: https://deploy-preview-4943--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4943--docusaurus-2.netlify.app/ |
|
Size Change: -12 B (0%) Total Size: 620 kB
ℹ️ View Unchanged
|
|
thanks 👍 looks exactly the same as before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3119
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Open Google Translate and try to translate page with code blocks on preview site -- its contents should remain untouched.
Markup errors were not detected (checked by Validator W3C Markup).
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)