fix(v2): redirect plugin should use siteConfig.trailingSlash #4988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The redirect plugin does not use the new
siteConfig.trailingSlash
config.It should, and output different patterns of redirect files according to
trailingSlash
Also, it should be more resilient:
redirect.to=/abc
and user wants to usetrailingSlash=true
/abc
is not a valid path to redirect to anymore => it is now/abc/
/abc/
automaticallytrailingSlash: true
without having to also update the redirect optionsAlso, it allows for easier
trailingSlash
dogfooding: we can now more easily changetrailingSlash
for our site prod/deployPreview without having to change redirect options (ie add/remove to trailing slashes in options => annoying)Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
tests