Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): remind running clear after swizzling #5044

Closed
wants to merge 2 commits into from

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

A common pitfall leading to many people asking "why doesn't docusaurus pick up my new component even after restarting dev server".

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 23, 2021
@netlify
Copy link

netlify bot commented Jun 23, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: b97fc6d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60d320937a226600077e3ded

😎 Browse the preview: https://deploy-preview-5044--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 50
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5044--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Jun 23, 2021

@Josh-Cena actually this is related to the new webpack 5 caching system. We shouldn't document this, instead, we should make it unnecessary to clear the cache by telling webpack it should evict it

@slorber slorber closed this Jun 23, 2021
@Josh-Cena Josh-Cena deleted the doc-swizzle branch June 23, 2021 15:03
@slorber
Copy link
Collaborator

slorber commented Jun 24, 2021

should be fixed by #5047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants