refactor: various tags improvements #5386
Conversation
lex111
added
the
pr: polish
|
✔️ [V2] 🔨 Explore the source changes: e2e1d4b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611ec2d9d20fcf00088bbaae 😎 Browse the preview: https://deploy-preview-5386--docusaurus-2.netlify.app |
|
Size Change: +1.63 kB (0%) Total Size: 811 kB
ℹ️ View Unchanged
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5386--docusaurus-2.netlify.app/ |
|
As an alternative (maybe better) option, we can use one single tag style regardless of target page. For example, on detail page of we had something like this:
Or like this (with additional heading, although if tags are styled as labels, it may not be necessary):
|
There was a problem hiding this comment.
LGTM thanks
Feel free to merge as it's already an improvement compared to what we had.
https://deploy-preview-5386--docusaurus-2.netlify.app/tests/docs/tags/
What about:
- Using a single design/comp, with an optional
countprop? That would allow customizing it more easily. - Show tag count in a rectangle instead of a circle/oval
The arrow design is a bit too opinionated for me and I prefer something soberer, but it's probably my own tastes. As you want. In the doc page, it would probably be soberer without the count anyway so I don't know 🤪
The tag count in oval does not scale well to large numbers:
It may be worth increasing the font-weight of that count too?
Some time age I saw how other blogs style tag items in this way, it seemed to me interesting option, which could be applied to us. @johnnyreilly you as blog user on Docusaurus, I want to hear your opinion on this redesign. |
|
I think this is a nice improvement. I don't actually use tags from the UI perspective a great deal, but I generally like this.
I agree with @slorber on this point. However, in my experience, it's unlikely that numbers of that scale will naturally occur. So I don't think it's too much of an issue |
Actually, I myself can't decide if need to use arrow-style anywhere else besides tag list. So let's keep things as is.
Just fixed all of the above. |
|
LGTM 👍 thanks |
Motivation
Just some small improvements after merge #3646:
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Tags:
Tag list:
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)