feat: infima 33 + navbar-sidebar close button #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 025f9c0 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/612fb97028751d0008b6cadb 😎 Browse the preview: https://deploy-preview-5460--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5460--docusaurus-2.netlify.app/ |
|
Size Change: +298 B (0%) Total Size: 822 kB
ℹ️ View Unchanged
|
|
Let's take icon from this PR facebookincubator/infima#174 instead of the current one if we decide to use same icon for both components. Since mobile navbar is always used (rather than announcement bar), it's better to have more appropriate to stylistically icon for it. |
lex111
reviewed
Sep 1, 2021
lex111
reviewed
Sep 1, 2021
packages/docusaurus-theme-classic/src/theme/IconClose/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add close button to navbar-sidebar
For consistency, reused the close button from the announcement bar
(different stroke width compared to the hamburger but this doesn't feel like a big deal as buttons are in different places)
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
preview
Related PRs
facebookincubator/infima#174